Fix clientSecret usage and adds test case #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 19, 2015 01:00
geek
added a commit
that referenced
this pull request
Jun 22, 2015
Fix clientSecret usage and adds test case
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This duplicate the fix from #101 and includes a proposed test case that would fail without the fix.
The previous suite of tests would complain if the user leaves off the clientSecret or gives it a value of undefined. But this particular bug happened at the point the clientSecret was assign as part of the query and then converted into a queryString. Since the wrong variable name was passed the query property client_secret was given a value of undefined. Then the queryString conversion method changed the undefined value into an empty string which is valid for a clientSecret.